Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: Source/core/dom/Document.h

Issue 304323010: Oilpan: have DocumentInit use transition types throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add WeakPtrWillBeMember transition type Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | Source/core/dom/DocumentInit.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 050ff54baefb140ccefe80c51cb908c3d5a4a917..dd4f66d0f7c5c1a48694724cd43f60101f8787ab 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -832,7 +832,7 @@ public:
Document* parentDocument() const;
Document& topDocument() const;
- WeakPtr<Document> contextDocument();
+ WeakPtrWillBeRawPtr<Document> contextDocument();
ScriptRunner* scriptRunner() { return m_scriptRunner.get(); }
@@ -1341,9 +1341,10 @@ private:
RenderView* m_renderView;
- // FIXME: Oilpan: We should use a real weak pointer here.
+#if !ENABLE(OILPAN)
WeakPtrFactory<Document> m_weakFactory;
- WeakPtr<Document> m_contextDocument;
+#endif
+ WeakPtrWillBeWeakMember<Document> m_contextDocument;
bool m_hasFullscreenElementStack; // For early return in FullscreenElementStack::fromIfExists()
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | Source/core/dom/DocumentInit.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698