Issue 304323005: Revert 273723 "Wire input events through the ViewManagerClient i..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304323005: Revert 273723 "Wire input events through the ViewManagerClient i..." (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273723 "Wire input events through the ViewManagerClient i..." > Wire input events through the ViewManagerClient interface. > > R=sky@chromium.org > http://crbug.com/365012 > > Review URL: https://codereview.chromium.org/300863003 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273735

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -169 lines)			Patch
M	trunk/src/mojo/examples/sample_view_manager_app/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	3 chunks	+1 line, -48 lines	0 comments	Download
M	trunk/src/mojo/mojo_services.gypi	View	4 chunks	+0 lines, -27 lines	0 comments	Download
M	trunk/src/mojo/services/native_viewport/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/mojo/services/native_viewport/native_viewport_service.cc	View	2 chunks	+27 lines, -5 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view_observer.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/node_delegate.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.cc	View	3 chunks	+0 lines, -18 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

6 years, 6 months ago (2014-05-30 06:14:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273735 (tree was closed).

Expand Messages | Collapse Messages