Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 304313002: Add testing for Rectanizer-derived classes (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add testing for Rectanizer-derived classes This in preparation for expanding the Rectanizer API for removing rects and adding a new derived class Committed: http://code.google.com/p/skia/source/detail?r=14972

Patch Set 1 #

Total comments: 4

Patch Set 2 : Renaming file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -258 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +3 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrRectanizer.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/GrRectanizer.cpp View 1 1 chunk +0 lines, -128 lines 0 comments Download
A src/gpu/GrRectanizer_pow2.h View 1 chunk +68 lines, -0 lines 0 comments Download
A + src/gpu/GrRectanizer_pow2.cpp View 1 2 chunks +3 lines, -65 lines 0 comments Download
A src/gpu/GrRectanizer_skyline.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
M src/gpu/GrRectanizer_skyline.cpp View 1 1 chunk +1 line, -51 lines 0 comments Download
A tests/GpuRectanizerTest.cpp View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 6 months ago (2014-05-29 18:05:24 UTC) #1
jvanverth1
LGTM + comments. https://codereview.chromium.org/304313002/diff/1/src/gpu/GrRectanizer.cpp File src/gpu/GrRectanizer.cpp (left): https://codereview.chromium.org/304313002/diff/1/src/gpu/GrRectanizer.cpp#oldcode2 src/gpu/GrRectanizer.cpp:2: /* Rename this file to GrRectanizer_pow2.cpp? ...
6 years, 6 months ago (2014-05-29 18:11:59 UTC) #2
robertphillips
https://codereview.chromium.org/304313002/diff/1/src/gpu/GrRectanizer.cpp File src/gpu/GrRectanizer.cpp (left): https://codereview.chromium.org/304313002/diff/1/src/gpu/GrRectanizer.cpp#oldcode2 src/gpu/GrRectanizer.cpp:2: /* On 2014/05/29 18:11:59, jvanverth1 wrote: > Rename this ...
6 years, 6 months ago (2014-05-29 18:37:02 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-05-29 18:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/304313002/20001
6 years, 6 months ago (2014-05-29 18:38:30 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 18:46:52 UTC) #6
Message was sent while issue was closed.
Change committed as 14972

Powered by Google App Engine
This is Rietveld 408576698