Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 304303006: Mojo: Specify/check alignment of pointers more carefully. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Specify/check alignment of pointers more carefully. Improve the verification routines especially in the case that no count is necessary. Also add a test. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274461

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Patch Set 3 : fix msvs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -62 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/system/core.cc View 9 chunks +19 lines, -16 lines 0 comments Download
M mojo/system/core_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/memory.h View 1 chunk +32 lines, -23 lines 0 comments Download
M mojo/system/memory.cc View 1 2 1 chunk +59 lines, -8 lines 0 comments Download
A mojo/system/memory_unittest.cc View 1 1 chunk +136 lines, -0 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
viettrungluu
6 years, 6 months ago (2014-05-30 21:38:59 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/304303006/diff/1/mojo/system/memory_unittest.cc File mojo/system/memory_unittest.cc (right): https://codereview.chromium.org/304303006/diff/1/mojo/system/memory_unittest.cc#newcode132 mojo/system/memory_unittest.cc:132: nit: extraneous newline
6 years, 6 months ago (2014-05-30 22:38:46 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/304303006/diff/1/mojo/system/memory_unittest.cc File mojo/system/memory_unittest.cc (right): https://codereview.chromium.org/304303006/diff/1/mojo/system/memory_unittest.cc#newcode132 mojo/system/memory_unittest.cc:132: On 2014/05/30 22:38:46, darin wrote: > nit: extraneous ...
6 years, 6 months ago (2014-05-30 23:04:16 UTC) #3
viettrungluu
Committed patchset #2 manually as r273936 (presubmit successful).
6 years, 6 months ago (2014-05-30 23:37:25 UTC) #4
DaleCurtis
A revert of this CL has been created in https://codereview.chromium.org/312463002/ by dalecurtis@chromium.org. The reason for ...
6 years, 6 months ago (2014-05-31 22:06:48 UTC) #5
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 6 months ago (2014-06-02 23:18:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/304303006/40001
6 years, 6 months ago (2014-06-02 23:20:10 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 03:44:52 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 10:37:18 UTC) #9
Message was sent while issue was closed.
Change committed as 274461

Powered by Google App Engine
This is Rietveld 408576698