Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: LayoutTests/inspector/jump-to-previous-editing-location.html

Issue 304303004: Revert of DevTools: even more logging for jump-to-previous-editing-location.html test (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/jump-to-previous-editing-location-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/jump-to-previous-editing-location.html
diff --git a/LayoutTests/inspector/jump-to-previous-editing-location.html b/LayoutTests/inspector/jump-to-previous-editing-location.html
index 79d50521120b3a5ed51589e2e96ca1aad6d52421..3fc1a1eb382ef62c344e3d279799cd8897c8c260 100644
--- a/LayoutTests/inspector/jump-to-previous-editing-location.html
+++ b/LayoutTests/inspector/jump-to-previous-editing-location.html
@@ -13,19 +13,9 @@
var sourcesView = panel._sourcesView;
var historyManager = sourcesView._historyManager;
var editorContainer = sourcesView._editorContainer;
- var shouldLogSimpleHistoryManager = false;
-
- function logSimpleHistoryManagerMethod(methodName)
- {
- if (!shouldLogSimpleHistoryManager)
- return;
- InspectorTest.addResult("SimpleHistoryManager." + methodName + " size: " + historyManager._historyManager._entries.length + " active: " + historyManager._historyManager._activeEntryIndex);
- }
- InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "push", logSimpleHistoryManagerMethod.bind(null, "push"), true);
- InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "active", logSimpleHistoryManagerMethod.bind(null, "active"), true);
- InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "rollback", logSimpleHistoryManagerMethod.bind(null, "rollback"), true);
- InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "rollover", logSimpleHistoryManagerMethod.bind(null, "rollover"), true);
- InspectorTest.addSniffer(WebInspector.SimpleHistoryManager.prototype, "filterOut", logSimpleHistoryManagerMethod.bind(null, "filterOut"), true);
+ InspectorTest.addSniffer(historyManager._historyManager, "filterOut", function() {
+ InspectorTest.addResult("executed SimpleHistoryManager.filterOut; activeEntryIndex = " + historyManager._historyManager._activeEntryIndex);
+ }, true);
function rollback()
{
@@ -60,7 +50,7 @@
dumpSelection(editor, "Mouse click (" + lineNumber + ", " + columnNumber + ")");
}
- function clickAndDump(editor, lines, columns, logLocation)
+ function clickAndDump(editor, lines, columns)
{
for (var i = 0; i < lines.length; ++i) {
var lineNumber = lines[i];
@@ -214,15 +204,13 @@
var editor = panel.visibleView.textEditor;
//FIXME(lushnikov): here and below excessive dumping to figure out a reason for
// unreproducible bot failures.
- shouldLogSimpleHistoryManager = true;
dumpSimpleHistoryManagerState("before filling history stack");
- clickAndDump(editor, lines, columns, true);
+ clickAndDump(editor, lines, columns);
dumpSimpleHistoryManagerState("after filling history stack");
InspectorTest.addResult("First rollback result: " + historyManager._historyManager.rollback());
dumpSimpleHistoryManagerState("after first rollback");
dumpSelection(editor, "Rolled back");
- shouldLogSimpleHistoryManager = false;
for (var i = 0; i < jumpsAmount - 1; ++i) {
rollback();
« no previous file with comments | « no previous file | LayoutTests/inspector/jump-to-previous-editing-location-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698