Issue 304303004: Revert of DevTools: even more logging for jump-to-previous-editing-location.html test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304303004: Revert of DevTools: even more logging for jump-to-previous-editing-location.html test (Closed)

Created:
6 years, 6 months ago by lushnikov

Modified:
6 years, 6 months ago

Reviewers:

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of DevTools: even more logging for jump-to-previous-editing-location.html test (https://codereview.chromium.org/298723005/) Reason for revert: Looks like test is not accidentally failing any more during last week. Reverting this debugging patch Original issue's description: > DevTools: even more logging for jump-to-previous-editing-location.html test > > Follow-up to r174282 to add some more logging into the test to figure out > why the test fails from time to time. The core problem seems to be due to > inconsistency in SimpleHistoryManager. > The patch be reverted after the reason will be determined. > > BUG=361588 > TBR=vsevik > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174502 TBR= NOTREECHECKS=true NOTRY=true BUG=361588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175113

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -61 lines)			Patch
	M	LayoutTests/inspector/jump-to-previous-editing-location.html	View		3 chunks	+5 lines, -17 lines	0 comments	Download
	M	LayoutTests/inspector/jump-to-previous-editing-location-expected.txt	View		3 chunks	+1 line, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lushnikov

Created Revert of DevTools: even more logging for jump-to-previous-editing-location.html test

6 years, 6 months ago (2014-05-30 08:45:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/304303004/1

6 years, 6 months ago (2014-05-30 08:46:02 UTC) #2

Message was sent while issue was closed.

Change committed as 175113

Expand Messages | Collapse Messages