Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 304303003: Make the rebaseline log server resilient to large logs. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Make the rebaseline log server resilient to large logs. Right now when it exceeds the appengine storage limit for a single entry it 500s. Instead, just create a new entry. This isn't totally ideal. Ideally we'd create a new entry but link it to the old one so we can show it correctly in the UI, but that's too much work. NOTRY=true BUG=378490 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M Tools/RebaselineLogServer/main.py View 2 chunks +7 lines, -1 line 0 comments Download
M Tools/RebaselineLogServer/main_unittest.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 6 months ago (2014-06-01 02:27:34 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-01 21:02:21 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-01 23:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/304303003/1
6 years, 6 months ago (2014-06-01 23:19:42 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 23:20:19 UTC) #5
Message was sent while issue was closed.
Change committed as 175230

Powered by Google App Engine
This is Rietveld 408576698