Chromium Code Reviews
Help | Chromium Project | Sign in
(16)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3043030: Move browser/first_run* into into a subdirectory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Evan Martin
Modified:
4 years ago
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, brettw-cc_chromium.org, pam+watch_chromium.org, kuchhal
Visibility:
Public.

Description

Move browser/first_run* into into a subdirectory. BUG=50548 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54226

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M chrome/app/chrome_exe_main_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/keystone_infobar.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run.h View 0 chunks +-1 lines, --1 lines 1 comment Download
A + chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/first_run/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/first_run_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/first_run_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/test_location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Evan Martin
4 years, 10 months ago (2010-07-29 22:22:13 UTC) #1
Paweł Hajdan Jr.
LGTM with a nit. http://codereview.chromium.org/3043030/diff/1/12 File chrome/browser/first_run/first_run.h (right): http://codereview.chromium.org/3043030/diff/1/12#newcode5 chrome/browser/first_run/first_run.h:5: #ifndef CHROME_BROWSER_FIRST_RUN_H_ nit: Header guards ...
4 years, 10 months ago (2010-07-29 22:46:50 UTC) #2
Miranda Callahan
4 years, 10 months ago (2010-07-29 23:36:16 UTC) #3 
LGTM with time nit.

http://codereview.chromium.org/3043030/diff/1/23
File chrome/browser/importer/toolbar_importer_unittest.cc (right):

http://codereview.chromium.org/3043030/diff/1/23#newcode1
chrome/browser/importer/toolbar_importer_unittest.cc:1: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
Nit: 2010
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be