Issue 3043007: [Isolates] Fix compile under Win32 and presumably for FreeBSD, OpenBS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3043007: [Isolates] Fix compile under Win32 and presumably for FreeBSD, OpenBS... (Closed)

Created:
10 years, 5 months ago by Maxim.Mossienko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium), Dmitry Titov, zarko, Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Fix compile / tests under Win32 and presumably for FreeBSD, OpenBSD, Solaris. Erroneous Isolate API stubs for Isolate::New / Isolate::GetCurrent were fixed. Thread and Sampler class constructors got Isolate attribute (same as in Linux and MacOSX), setting Isolate::isolate_key for new threads in each platform' ThreadEntry() function. Removed no longer used ContextSwitcher::singleton_ , ContextSwitcher::isolate_ (there is isolate_ in superclass). Added OS::Setup(); to test-platform-win32.cc#testVirtualMemory to avoid crash.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -23 lines)			Patch
M	src/api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	src/platform-nullos.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform-openbsd.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	src/platform-solaris.cc	View	1 2	3 chunks	+9 lines, -3 lines	0 comments	Download
M	src/platform-win32.cc	View	1 2	3 chunks	+10 lines, -3 lines	0 comments	Download
M	src/v8threads.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/v8threads.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-platform-win32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Maxim.Mossienko

Come on guys, please review this straightforward fix for COMPILATION problems.

10 years, 5 months ago (2010-07-20 15:32:56 UTC) #2

zarko

On 2010/07/20 15:32:56, Maxim.Mossienko wrote: > Come on guys, please review this straightforward fix for ...

10 years, 5 months ago (2010-07-20 17:50:41 UTC) #3

zarko

10 years, 5 months ago (2010-07-20 18:16:19 UTC) #4

On 2010/07/20 17:50:41, zarko wrote:
> On 2010/07/20 15:32:56, Maxim.Mossienko wrote:
> > Come on guys, please review this straightforward fix for COMPILATION
problems.
> 
> LGTM

Landed in r5104 (http://code.google.com/p/v8/source/detail?r=5104). Thanks!

Expand Messages | Collapse Messages

Issue 3043007: [Isolates] Fix compile under Win32 and presumably for FreeBSD, OpenBS... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages