tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate - Issue 304293005: Have the same behavior for setting a CSS style to null versus empty string in all browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

Issue 304293005: Have the same behavior for setting a CSS style to null versus empty string in all browsers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate b/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

index ca83f233e9af92ffa43e9ac66fb80a5f7cb5f6b5..c7d1075ed41ae5fe355e730e323aafb5c13c97a7 100644

--- a/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

+++ b/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

@@ -24,6 +24,7 @@ $if DART2JS

void setProperty(String propertyName, String value, [String priority]) {

// try/catch for IE9 which throws on unsupported values.

try {

+ if (value == null) value = '';

if (priority == null) {

priority = '';

}

« no previous file with comments | « tests/html/cssstyledeclaration_test.dart ('k') | no next file » | no next file with comments »