sdk/lib/html/dart2js/html_dart2js.dart - Issue 304293005: Have the same behavior for setting a CSS style to null versus empty string in all browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 304293005: Have the same behavior for setting a CSS style to null versus empty string in all browsers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index f3f1b8dea834495f266d111f4ea31e06798b221b..837b88710d3a928673022dacae1868b2974e7470 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -2808,6 +2808,7 @@ class CssRule extends Interceptor native "CSSRule" {

void setProperty(String propertyName, String value, [String priority]) {

// try/catch for IE9 which throws on unsupported values.

try {

+ if (value == null) value = '';

if (priority == null) {

priority = '';

}

« no previous file with comments | « no previous file | tests/html/cssstyledeclaration_test.dart » ('j') | no next file with comments »