Use response files in the GN build for shared libs and executables

Use response files in the GN build for shared libs and executables

We already blow out the command-line length limit on one of the bots.

TBR=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273859

[brettw, 2014-05-30 00:49:31]

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
build/toolchain/gcc_toolchain.gni:84: rspfile_content = "-Wl,--whole-archive
\$in \$solibs -Wl,--no-whole-archive \$libs"
This is copied from GYP. Not sure why it includes these flags in the rspfile.

[brettw, 2014-05-30 16:31:25]

Committed patchset #2 manually as r273859 (presubmit successful).

[Nico, 2014-05-30 16:37:24]

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
build/toolchain/gcc_toolchain.gni:83: rspfile = "\$out.rsp"
Note that this won't work on OS X in ninja 1.4, the current version, because
"Chromium Framework" contains a space, so $out becomes `"Chromium Framework"`
(with quotes) and ninja will write the rspfile to `"Chromium Framework".rsp`
(with quotes).

This is fixed on trunk, and 1.5 should hopefully be in depot_tools within a
month.

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
build/toolchain/gcc_toolchain.gni:84: rspfile_content = "-Wl,--whole-archive
\$in \$solibs -Wl,--no-whole-archive \$libs"
On 2014/05/30 00:49:31, brettw wrote:
> This is copied from GYP. Not sure why it includes these flags in the rspfile.

Doesn't matter too much I suppose; I felt putting most stuff into the rspfile is
more consistent when I did the gyp change iirc

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
File build/toolchain/mac/BUILD.gn (left):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
build/toolchain/mac/BUILD.gn:84: description = "LIBTOOL-STATIC \$out,
POSTBUILDS"
postbuilds usually take most of the time, so omitting them from the description
is a bit misleading

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
build/toolchain/mac/BUILD.gn:85: rspfile = "\$out.rsp"
Oh, I suppose my comment about spaces is more appropriate here than in the linux
file.

[brettw, 2014-05-30 17:24:38]

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/gcc_tool...
build/toolchain/gcc_toolchain.gni:83: rspfile = "\$out.rsp"
On 2014/05/30 16:37:24, Nico (traveling) wrote:
> Note that this won't work on OS X in ninja 1.4, the current version, because
> "Chromium Framework" contains a space, so $out becomes `"Chromium Framework"`
> (with quotes) and ninja will write the rspfile to `"Chromium Framework".rsp`
> (with quotes).
> 
> This is fixed on trunk, and 1.5 should hopefully be in depot_tools within a
> month.

Okay, I require a trunk Ninja build for Windows to work, too, so this seems like
par for the course.

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
File build/toolchain/mac/BUILD.gn (left):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
build/toolchain/mac/BUILD.gn:84: description = "LIBTOOL-STATIC \$out,
POSTBUILDS"
On 2014/05/30 16:37:24, Nico (traveling) wrote:
> postbuilds usually take most of the time, so omitting them from the
description
> is a bit misleading

We don't do any postbuilds. Anything that's required in a post-build step still
needs to be figured out (hint hint!) and I didn't want to imply here that we
were doing any!

[Nico, 2014-05-30 17:35:38]

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
File build/toolchain/mac/BUILD.gn (left):

https://codereview.chromium.org/304293003/diff/20001/build/toolchain/mac/BUIL...
build/toolchain/mac/BUILD.gn:84: description = "LIBTOOL-STATIC \$out,
POSTBUILDS"
On 2014/05/30 17:24:39, brettw wrote:
> On 2014/05/30 16:37:24, Nico (traveling) wrote:
> > postbuilds usually take most of the time, so omitting them from the
> description
> > is a bit misleading
> 
> We don't do any postbuilds. Anything that's required in a post-build step
still
> needs to be figured out (hint hint!) and I didn't want to imply here that we
> were doing any!

That's a good point :-)

[jamesr, 2014-06-01 23:45:11]

No luck for me on OS X:

$ ls -l out_gn/Debug/libevent.a.rsp 
-rw-r--r--  1 jamesr  staff  601 Jun  1 16:42 out_gn/Debug/libevent.a.rsp
jamesr-mbp-retina:src jamesr$ ninja -C out_gn/Debug libevent -v
ninja: Entering directory `out_gn/Debug'
[1/1] rm -f libevent.a && ./gyp-mac-tool filter-libtool libtool  -static -o
libevent.a @libevent.a.rsp 
FAILED: rm -f libevent.a && ./gyp-mac-tool filter-libtool libtool  -static -o
libevent.a @libevent.a.rsp 
error:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
can't open file: @libevent.a.rsp (No such file or directory)
ninja: build stopped: subcommand failed.

I'm using the gn and ninja binaries from depot_tools (version 271709 and 1.4.0
respectively).

I can't figure out what the rsp syntax is supposed to be for libtool, either. 
Do we use them anywhere else?

[jamesr, 2014-06-01 23:52:17]

If i replace spaces with newlines in the .rsp file and pass it to libtool with
'-filelist foo.rsp' instead of '@foo.rsp' then it links something.  I can't
figure out where the .rsp file is written to

[Nico, 2014-06-02 08:07:05]

On 2014/06/01 23:45:11, jamesr wrote:
> No luck for me on OS X:
> 
> $ ls -l out_gn/Debug/libevent.a.rsp 
> -rw-r--r--  1 jamesr  staff  601 Jun  1 16:42 out_gn/Debug/libevent.a.rsp
> jamesr-mbp-retina:src jamesr$ ninja -C out_gn/Debug libevent -v
> ninja: Entering directory `out_gn/Debug'
> [1/1] rm -f libevent.a && ./gyp-mac-tool filter-libtool libtool  -static -o
> libevent.a @libevent.a.rsp 
> FAILED: rm -f libevent.a && ./gyp-mac-tool filter-libtool libtool  -static -o
> libevent.a @libevent.a.rsp 
> error:
>
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
> can't open file: @libevent.a.rsp (No such file or directory)
> ninja: build stopped: subcommand failed.
> 
> I'm using the gn and ninja binaries from depot_tools (version 271709 and 1.4.0
> respectively).

As mentioned upthread, depot_tools ninja is no longer good enough after this
change (but not because of libtool, because of ld and spaces in filenames) - you
need trunk.

…but it looks like https://codereview.chromium.org/197823008/ doesn't use
rspfiles for alink in gyp. I suppose libtool just doesn't suppose the @ syntax,
so the alink patch of this patch needs to be undone, or use -filelist I suppose.
Sorry for missing this.

> I can't figure out where the .rsp file is written to

(You can pass `-d keeprsp` to ninja to make it not delete rspfiles right after
using them.)