chrome/test/data/extensions/api_test/automation/tests/tabs/location.js - Issue 304293002: Add human readable programmatic enum name/values to chrome.automation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

Issue 304293002: Add human readable programmatic enum name/values to chrome.automation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Last feedback. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/tabs/events.js ('k') | chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

index c05fdad4880628863a128845321fa741f95d9cde..da6d71c8890372d193ecb3f9beb8e4961dc4b425 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/location.js

@@ -19,7 +19,8 @@ var allTests = [

assertTrue('height' in okButton.location, 'no height in location');

assertTrue('width' in okButton.location, 'no width in location');

- tree.root.addEventListener('childrenChanged', assertOkButtonLocation);

+ tree.root.addEventListener(

+ EventType.childrenChanged, assertOkButtonLocation);

chrome.tabs.executeScript({ 'code':

'document.querySelector("button")' +

'.setAttribute("style", "position: absolute; left: 100; top: 200; ' +