Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: components/history/core/common/thumbnail_score.cc

Issue 304273010: Move thumbnail to history component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to ToT and formatting code Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/common/thumbnail_score.cc
diff --git a/chrome/common/thumbnail_score.cc b/components/history/core/common/thumbnail_score.cc
similarity index 87%
rename from chrome/common/thumbnail_score.cc
rename to components/history/core/common/thumbnail_score.cc
index 5d3d698f1a8c23e2ea412eeac2aa0b70e5712a73..a8d7d8aa1eb7259c46b19174d02c28ce7bba1c60 100644
--- a/chrome/common/thumbnail_score.cc
+++ b/components/history/core/common/thumbnail_score.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/thumbnail_score.h"
+#include "components/history/core/common/thumbnail_score.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
@@ -48,7 +48,9 @@ ThumbnailScore::ThumbnailScore(double score, bool clipping, bool top)
redirect_hops_from_dest(0) {
}
-ThumbnailScore::ThumbnailScore(double score, bool clipping, bool top,
+ThumbnailScore::ThumbnailScore(double score,
+ bool clipping,
+ bool top,
const Time& time)
: boring_score(score),
good_clipping(clipping),
@@ -63,10 +65,9 @@ ThumbnailScore::~ThumbnailScore() {
bool ThumbnailScore::Equals(const ThumbnailScore& rhs) const {
return boring_score == rhs.boring_score &&
- good_clipping == rhs.good_clipping &&
- at_top == rhs.at_top &&
- time_at_snapshot == rhs.time_at_snapshot &&
- redirect_hops_from_dest == rhs.redirect_hops_from_dest;
+ good_clipping == rhs.good_clipping && at_top == rhs.at_top &&
+ time_at_snapshot == rhs.time_at_snapshot &&
+ redirect_hops_from_dest == rhs.redirect_hops_from_dest;
}
std::string ThumbnailScore::ToString() const {
@@ -90,7 +91,7 @@ bool ShouldReplaceThumbnailWith(const ThumbnailScore& current,
// If we have a better class of thumbnail, add it if it meets
// certain minimum boringness.
return replacement.boring_score <
- ThumbnailScore::kThumbnailMaximumBoringness;
+ ThumbnailScore::kThumbnailMaximumBoringness;
} else if (replacement_type == current_type) {
// It's much easier to do the scaling below when we're dealing with "higher
// is better." Then we can decrease the score by dividing by a fraction.
@@ -102,8 +103,7 @@ bool ShouldReplaceThumbnailWith(const ThumbnailScore& current,
// Degrade the score of each thumbnail to account for how many redirects
// they are away from the destination. 1/(x+1) gives a scaling factor of
// one for x = 0, and asymptotically approaches 0 for larger values of x.
- current_interesting_score *=
- 1.0 / (current.redirect_hops_from_dest + 1);
+ current_interesting_score *= 1.0 / (current.redirect_hops_from_dest + 1);
replacement_interesting_score *=
1.0 / (replacement.redirect_hops_from_dest + 1);
@@ -113,7 +113,7 @@ bool ShouldReplaceThumbnailWith(const ThumbnailScore& current,
TimeDelta time_between_thumbnails =
replacement.time_at_snapshot - current.time_at_snapshot;
current_interesting_score -= time_between_thumbnails.InHours() *
- ThumbnailScore::kThumbnailDegradePerHour;
+ ThumbnailScore::kThumbnailDegradePerHour;
if (current_interesting_score < kThumbnailMinimumInterestingness)
current_interesting_score = kThumbnailMinimumInterestingness;
@@ -125,7 +125,7 @@ bool ShouldReplaceThumbnailWith(const ThumbnailScore& current,
// requirements, but the replacement does, always replace the
// current one even if we're using a worse thumbnail type.
return current.boring_score >= ThumbnailScore::kThumbnailMaximumBoringness &&
- replacement.boring_score < ThumbnailScore::kThumbnailMaximumBoringness;
+ replacement.boring_score < ThumbnailScore::kThumbnailMaximumBoringness;
}
bool ThumbnailScore::ShouldConsiderUpdating() {
« no previous file with comments | « components/history/core/common/thumbnail_score.h ('k') | components/history/core/common/thumbnail_score_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698