Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: pkg/analysis_server/test/domain_analysis_test.dart

Issue 304273007: Use 'analysis.setSubscriptions' HIGHLIGHTS in Editor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use addAnalysisSubscription/removeAnalysisSubscription Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/domain_server.dart ('k') | pkg/analysis_server/test/domain_server_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_analysis_test.dart
diff --git a/pkg/analysis_server/test/domain_analysis_test.dart b/pkg/analysis_server/test/domain_analysis_test.dart
index 1b5ab845a9643d90e67a4e2fca58d5311620de1b..fc429e37cf8d377f73e77058fe073d6dfbf2b595 100644
--- a/pkg/analysis_server/test/domain_analysis_test.dart
+++ b/pkg/analysis_server/test/domain_analysis_test.dart
@@ -208,7 +208,7 @@ class AnalysisTestHelper {
}
files.add(file);
// set subscriptions
- Request request = new Request('0', METHOD_SET_SUBSCRIPTIONS);
+ Request request = new Request('0', METHOD_SET_ANALYSIS_SUBSCRIPTIONS);
request.setParameter(SUBSCRIPTIONS, analysisSubscriptions);
handleSuccessfulRequest(request);
}
@@ -1146,15 +1146,7 @@ void test_setSubscriptions() {
test('before analysis', () {
AnalysisTestHelper helper = new AnalysisTestHelper();
// subscribe
- {
- var request = new Request('0', METHOD_SET_SUBSCRIPTIONS);
- request.setParameter(
- SUBSCRIPTIONS,
- {
- AnalysisService.HIGHLIGHTS.name : [helper.testFile],
- });
- helper.handleSuccessfulRequest(request);
- }
+ helper.addAnalysisSubscriptionHighlight(helper.testFile);
// create project
helper.createSingleFileProject('int V = 42;');
// wait, there are highlight regions
@@ -1173,15 +1165,7 @@ void test_setSubscriptions() {
var highlights = helper.getHighlights(helper.testFile);
expect(highlights, isEmpty);
// subscribe
- {
- var request = new Request('0', METHOD_SET_SUBSCRIPTIONS);
- request.setParameter(
- SUBSCRIPTIONS,
- {
- AnalysisService.HIGHLIGHTS.name : [helper.testFile],
- });
- helper.handleSuccessfulRequest(request);
- }
+ helper.addAnalysisSubscriptionHighlight(helper.testFile);
// wait, has regions
return helper.waitForTasksFinished().then((_) {
var highlights = helper.getHighlights(helper.testFile);
« no previous file with comments | « pkg/analysis_server/lib/src/domain_server.dart ('k') | pkg/analysis_server/test/domain_server_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698