Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Issue 304273005: Increase repaint test delay when running in browser (Closed)

Created:
6 years, 6 months ago by Xianzhu
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Increase repaint test delay when running in browser When running a repaint test in browser, sometimes we may want to see the page contents before and after repaintTest(). The origianl 100ms delay seems too short to show the page contents before repaintTest(). This may be more useful when we have repaint overlay feature when showing layout test results (https://codereview.chromium.org/303223008/). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
6 years, 6 months ago (2014-05-30 18:03:54 UTC) #1
Xianzhu
6 years, 6 months ago (2014-05-30 18:06:07 UTC) #2
Dirk Pranke
That seems like a fairly large timeout increase. How many tests use this? Does this ...
6 years, 6 months ago (2014-05-30 18:13:22 UTC) #3
Xianzhu
On 2014/05/30 18:13:22, Dirk Pranke wrote: > That seems like a fairly large timeout increase. ...
6 years, 6 months ago (2014-05-30 18:31:20 UTC) #4
Dirk Pranke
On 2014/05/30 18:31:20, Xianzhu wrote: > On 2014/05/30 18:13:22, Dirk Pranke wrote: > > That ...
6 years, 6 months ago (2014-05-30 18:49:57 UTC) #5
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-05-30 18:51:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/304273005/1
6 years, 6 months ago (2014-05-30 18:52:11 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:52:39 UTC) #8
Message was sent while issue was closed.
Change committed as 175165

Powered by Google App Engine
This is Rietveld 408576698