Issue 304273004: Add name to services

Issue 304273004: Add name to services (Closed)

Created:
6 years, 6 months ago by DaveMoore

Modified:
6 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add name to services R=darin@chromium.org, darin BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273912

Patch Set 1 #

Patch Set 2 : Add name to services #

Patch Set 3 : Merge #

Patch Set 4 : Get chrome to build #

Patch Set 5 : Get chrome to build #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -50 lines)			Patch
M	content/browser/mojo/mojo_application_host.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/mojo/mojo_application_host.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/child/child_thread.h	View	1 2 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/child/child_thread.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/render_thread_impl.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/application/application.h	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	mojo/public/cpp/application/connect.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/public/cpp/application/lib/application.cc	View	1 2 3 4	2 chunks	+17 lines, -19 lines	0 comments	Download
M	mojo/public/cpp/application/lib/service_connector.h	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	mojo/public/cpp/bindings/lib/no_interface.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/public/cpp/bindings/no_interface.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/interfaces/service_provider/service_provider.mojom	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/service_manager/service_manager.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	mojo/service_manager/service_manager.cc	View	1 2	4 chunks	+10 lines, -6 lines	0 comments	Download
M	mojo/service_manager/service_manager_unittest.cc	View	1 2 3	4 chunks	+9 lines, -6 lines	0 comments	Download
M	mojo/services/public/interfaces/view_manager/view_manager.mojom	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/view_manager/root_node_manager.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/shell/run.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/shell/shell_test_helper.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM note: String implicitly converts to |const std::string&|. No need for .To<std::string>.

6 years, 6 months ago (2014-05-30 16:01:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/304273004/80001

6 years, 6 months ago (2014-05-30 18:10:59 UTC) #8

DaveMoore

6 years, 6 months ago (2014-05-30 21:33:08 UTC) #9

Message was sent while issue was closed.

Committed patchset #5 manually as r273912 (presubmit successful).

Expand Messages | Collapse Messages