Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 304273002: Remove WebPopupMenuImpl::enterForceCompositingMode (Closed)

Created:
6 years, 6 months ago by jbauman
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove WebPopupMenuImpl::enterForceCompositingMode Create the compositor in WebPopupMenuImpl::initialize because it's always going to be used. BUG=378029 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -38 lines) Patch
M Source/web/WebPopupMenuImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 4 chunks +13 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbauman
6 years, 6 months ago (2014-05-29 17:25:16 UTC) #1
ojan
lgtm Nice!
6 years, 6 months ago (2014-05-30 00:43:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/304273002/1
6 years, 6 months ago (2014-05-30 00:44:01 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-30 01:57:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 08:47:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9556)
6 years, 6 months ago (2014-05-30 08:48:00 UTC) #6
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-05-30 18:26:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/304273002/1
6 years, 6 months ago (2014-05-30 18:27:44 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:43:15 UTC) #9
Message was sent while issue was closed.
Change committed as 175160

Powered by Google App Engine
This is Rietveld 408576698