Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 304253005: Make the contextual search flag tri-state. This allows users to opt-out even if they're in the Fin… (Closed)

Created:
6 years, 6 months ago by jeremycho
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make the contextual search flag tri-state. This allows users to opt-out even if they're in the Finch trial. BUG=378999 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
donnd
lgtm LGTM, Thanks Jeremy!
6 years, 6 months ago (2014-05-29 23:57:19 UTC) #1
jeremycho
The CQ bit was checked by jeremycho@chromium.org
6 years, 6 months ago (2014-05-30 00:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremycho@chromium.org/304253005/1
6 years, 6 months ago (2014-05-30 00:11:19 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 00:11:20 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-30 00:11:20 UTC) #5
pedro (no code reviews)
lgtm
6 years, 6 months ago (2014-05-30 00:15:44 UTC) #6
jeremycho
The CQ bit was checked by jeremycho@chromium.org
6 years, 6 months ago (2014-05-30 00:15:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremycho@chromium.org/304253005/1
6 years, 6 months ago (2014-05-30 00:18:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 00:18:54 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-30 00:18:55 UTC) #10
jeremycho
Hi James - can you review for the committer approval? Thanks!
6 years, 6 months ago (2014-05-30 00:22:34 UTC) #11
James Hawkins
lgtm
6 years, 6 months ago (2014-05-30 00:24:53 UTC) #12
jeremycho
The CQ bit was checked by jeremycho@chromium.org
6 years, 6 months ago (2014-05-30 00:46:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremycho@chromium.org/304253005/1
6 years, 6 months ago (2014-05-30 00:48:04 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 08:26:09 UTC) #15
Message was sent while issue was closed.
Change committed as 273772

Powered by Google App Engine
This is Rietveld 408576698