Issue 304223012: Fixes crash of SetGtkTransientForAura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304223012: Fixes crash of SetGtkTransientForAura. (Closed)

Created:
6 years, 6 months ago by Jun Mukai

Modified:
6 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes crash of SetGtkTransientForAura. The crash report is saying that the crash still happens in Aura. I still don't get the repro steps, but on possibility is that the parent exists but WindowTreeHost doesn't exist (missing root windows? I don't even know that is possible though...). BUG=373522 R=erg@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274341

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/libgtk2ui/gtk2_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/304223012/1

6 years, 6 months ago (2014-06-02 17:29:44 UTC) #4

Message was sent while issue was closed.

Change committed as 274341

Expand Messages | Collapse Messages