Issue 304223009: Do more work on content/browser GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304223009: Do more work on content/browser GN build (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, vsevik, tfarina, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do more work on content/browser GN build Adds support for the devtools generated resources. Still doesn't compile, but getting closer. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274026

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -3 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/BUILD.gn	View	3 chunks	+4 lines, -2 lines	0 comments	Download
A	content/browser/devtools/BUILD.gn	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	content/public/browser/BUILD.gn	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/tools/grit/grit_rule.gni	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

The new work requires this Blink patch to add the devtools resources: https://codereview.chromium.org/302093008/

6 years, 6 months ago (2014-05-30 23:36:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/304223009/1

6 years, 6 months ago (2014-05-31 04:12:19 UTC) #4

brettw

6 years, 6 months ago (2014-05-31 04:46:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r274026 (presubmit successful).

Expand Messages | Collapse Messages