Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: make constructors explicit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp
index c4a9aa645d230d8379f08551e0f9ecbc12f3e5be..2cac0757dd1c53fa325a4e11aa508a1762ca0a2d 100644
--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp
@@ -83,6 +83,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestInterfaceWillBeGarbageCollected* arg;
{
v8::TryCatch block;
+ V8RethrowTryCatchScope rethrow(block);
TONATIVE_VOID_INTERNAL(arg, V8TestInterfaceWillBeGarbageCollected::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
}
impl->func(arg);
@@ -104,7 +105,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
}
V8StringResource<> str;
{
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(str, info[0]);
+ TOSTRING_VOID_INTERNAL(str, info[0]);
}
RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::create(str);
@@ -151,7 +152,7 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F
}
V8StringResource<> str;
{
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(str, info[0]);
+ TOSTRING_VOID_INTERNAL(str, info[0]);
}
RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::createForJSConstructor(*document, str);
« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698