Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/bindings/tests/results/V8TestInterface2.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: make constructors explicit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterface2.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface2.cpp b/Source/bindings/tests/results/V8TestInterface2.cpp
index 78cf2c39c3cefb2c8f26099fc7073454a48a8df7..8402e1e18bf6fec820871bdc7eec0da11449f28d 100644
--- a/Source/bindings/tests/results/V8TestInterface2.cpp
+++ b/Source/bindings/tests/results/V8TestInterface2.cpp
@@ -58,6 +58,7 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
unsigned index;
{
v8::TryCatch block;
+ V8RethrowTryCatchScope rethrow(block);
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);
}
RefPtr<TestInterfaceEmpty> result = impl->item(index, exceptionState);
@@ -87,6 +88,7 @@ static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
V8StringResource<> value;
{
v8::TryCatch block;
+ V8RethrowTryCatchScope rethrow(block);
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);
TOSTRING_VOID_INTERNAL(value, info[1]);
}
@@ -116,6 +118,7 @@ static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
unsigned index;
{
v8::TryCatch block;
+ V8RethrowTryCatchScope rethrow(block);
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);
}
bool result = impl->deleteItem(index, exceptionState);
@@ -143,7 +146,7 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
TestInterface2* impl = V8TestInterface2::toNative(info.Holder());
V8StringResource<> name;
{
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(name, info[0]);
+ TOSTRING_VOID_INTERNAL(name, info[0]);
}
RefPtr<TestInterfaceEmpty> result = impl->namedItem(name, exceptionState);
if (exceptionState.hadException()) {
@@ -171,8 +174,8 @@ static void setNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
V8StringResource<> name;
V8StringResource<> value;
{
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(name, info[0]);
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(value, info[1]);
+ TOSTRING_VOID_INTERNAL(name, info[0]);
+ TOSTRING_VOID_INTERNAL(value, info[1]);
}
String result = impl->setNamedItem(name, value, exceptionState);
if (exceptionState.hadException()) {
@@ -199,7 +202,7 @@ static void deleteNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& inf
TestInterface2* impl = V8TestInterface2::toNative(info.Holder());
V8StringResource<> name;
{
- TOSTRING_VOID_INTERNAL_NOTRYCATCH(name, info[0]);
+ TOSTRING_VOID_INTERNAL(name, info[0]);
}
bool result = impl->deleteNamedItem(name, exceptionState);
if (exceptionState.hadException()) {
« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698