Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: make constructors explicit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index adf7d3d90d1968f3ba44667bc313985f6a64d8c1..b50ba604efeda5d30d6904c14ab2371aec03b82c 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -100,7 +100,7 @@ def generate_method(interface, method):
return {
'activity_logging_world_list': v8_utilities.activity_logging_world_list(method), # [ActivityLogging]
- 'arguments': [generate_argument(interface, method, argument, index, arguments_need_try_catch)
+ 'arguments': [generate_argument(interface, method, argument, index)
for index, argument in enumerate(arguments)],
'arguments_need_try_catch': arguments_need_try_catch,
'conditional_string': v8_utilities.conditional_string(method),
@@ -157,7 +157,7 @@ def generate_method(interface, method):
}
-def generate_argument(interface, method, argument, index, method_has_try_catch):
+def generate_argument(interface, method, argument, index):
extended_attributes = argument.extended_attributes
idl_type = argument.idl_type
this_cpp_value = cpp_value(interface, method, index)
@@ -195,7 +195,7 @@ def generate_argument(interface, method, argument, index, method_has_try_catch):
'name': argument.name,
'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),
'v8_set_return_value': v8_set_return_value(interface.name, method, this_cpp_value),
- 'v8_value_to_local_cpp_value': v8_value_to_local_cpp_value(argument, index, method_has_try_catch),
+ 'v8_value_to_local_cpp_value': v8_value_to_local_cpp_value(argument, index),
}
@@ -279,7 +279,7 @@ def v8_value_to_local_cpp_variadic_value(argument, index):
return '%s(%s)' % (macro, ', '.join(macro_args))
-def v8_value_to_local_cpp_value(argument, index, method_has_try_catch):
+def v8_value_to_local_cpp_value(argument, index):
extended_attributes = argument.extended_attributes
idl_type = argument.idl_type
name = argument.name
@@ -292,8 +292,7 @@ def v8_value_to_local_cpp_value(argument, index, method_has_try_catch):
else:
v8_value = 'info[%s]' % index
return idl_type.v8_value_to_local_cpp_value(extended_attributes, v8_value,
- name, index=index, declare_variable=False,
- method_has_try_catch=method_has_try_catch)
+ name, index=index, declare_variable=False)
################################################################################
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698