Source/bindings/v8/custom/V8DocumentCustom.cpp - Issue 304223007: Use auto-rethrowing v8::TryCatch variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8DocumentCustom.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add/use yhirano's scope classes instead Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/v8/custom/V8DocumentCustom.cpp b/Source/bindings/v8/custom/V8DocumentCustom.cpp

index fcf60021ebac6970a3d35d7b4faaad660684f808..4248ff3b33ed9c5e1129041665b24f9e6e1dd35e 100644

--- a/Source/bindings/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/v8/custom/V8DocumentCustom.cpp

@@ -97,7 +97,7 @@ void V8Document::createEventMethodCustom(const v8::FunctionCallbackInfo<v8::Valu

Document* impl = V8Document::toNative(info.Holder());

V8StringResource<> eventType;

{

- TOSTRING_VOID_INTERNAL_NOTRYCATCH(eventType, info[0]);

+ TOSTRING_VOID_INTERNAL(eventType, info[0]);

}

RefPtrWillBeRawPtr<Event> result = createEventModules(eventType, exceptionState);

if (exceptionState.hadException()) {