Source/bindings/tests/results/V8TestInterfaceNode.cpp - Issue 304223007: Use auto-rethrowing v8::TryCatch variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNode.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add/use yhirano's scope classes instead Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestInterfaceNode.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/V8TestInterfaceNode.cpp

index aef8da0799258e5ae127ea6153947c8017c93b70..b0e13a6a4b9c09ba3bbb77a2e7af0d8c18ebcc52 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNode.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNode.cpp

@@ -252,6 +252,7 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethod(con

bool optionalBooleanArgument;

{

v8::TryCatch block;

+ V8RethrowTryCatchScope rethrow(block);

if (UNLIKELY(info.Length() <= 0)) {

v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()), impl);

return;

@@ -274,6 +275,7 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodForM

bool optionalBooleanArgument;

{

v8::TryCatch block;

+ V8RethrowTryCatchScope rethrow(block);

if (UNLIKELY(info.Length() <= 0)) {

v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()));

return;