Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 304223007: Use auto-rethrowing v8::TryCatch variant (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 916c84148456587a745e96ad7a2f1d2a71f6692e..d0c8b6eb1ab445e4ed5219c68cc42744526308fc 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -80,7 +80,7 @@ if (listener && !impl->toNode())
{% endfor %}
{
{% if method.arguments_need_try_catch %}
- v8::TryCatch block;
+ V8TryPropagate block;
{% endif %}
{% for argument in method.arguments %}
{{generate_argument(method, argument, world_suffix) | indent}}
@@ -295,9 +295,6 @@ throwTypeError(ExceptionMessages::failedToConstruct("{{interface_name}}", {{erro
{% else %}{# method.has_exception_state #}
throwTypeError(ExceptionMessages::failedToExecute("{{method.name}}", "{{interface_name}}", {{error_message}}), info.GetIsolate());
{% endif %}
-{% if method.arguments_need_try_catch %}
-block.ReThrow();
-{%- endif %}{# method.has_exception_state #}
{% endmacro %}

Powered by Google App Engine
This is Rietveld 408576698