Use auto-rethrowing v8::TryCatch variant

Source/bindings/v8/V8BindingMacros.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
 #define TONATIVE_EXCEPTION(type, var, value) \
     type var;                                \
     {                                        \
         v8::TryCatch block;                  \
         var = (value);                       \
         if (UNLIKELY(block.HasCaught()))     \
             return block.ReThrow();          \
     }
 
 #define TONATIVE_VOID_INTERNAL(var, value) \
-    var = (value);                        \
-    if (UNLIKELY(block.HasCaught())) {    \
-        block.ReThrow();                  \
-        return;                           \
-    }
+    var = (value);                         \
+    if (UNLIKELY(block.HasCaught()))       \
+        return;
 
-#define TONATIVE_VOID(type, var, value)    \
-    type var;                              \
-    {                                      \
-        v8::TryCatch block;                \
-        TONATIVE_VOID_INTERNAL(var, value); \
+#define TONATIVE_VOID(type, var, value)        \
+    type var;                                  \
+    {                                          \
+        v8::TryCatch block;                    \
+        V8RethrowTryCatchScope rethrow(block); \

[haraken, 2014/05/30 11:58:25]

In my understanding, V8RethrowTryCatchScope should always be coupled with
v8::TryCatch. Would it be possible to merge the two classes, so that we can just
write this as:

V8TryCatchRethrowScope scope;

?

[yhirano, 2014/05/30 12:06:58]

I would like to "overwrite" V8RethrowTryCatchScope's effect by placing another
V8ResetTryCatchScope inside its scope (and that's why V8ResetTryCatchScope
exists), in another CL.

+        TONATIVE_VOID_INTERNAL(var, value);    \
     }
 
 #define TONATIVE_DEFAULT(type, var, value, retVal) \
     type var;                                      \
     {                                              \
         v8::TryCatch block;                        \
         var = (value);                             \
         if (UNLIKELY(block.HasCaught())) {         \
             block.ReThrow();                       \
             return retVal;                         \
@@ skipping 28 matching lines @@
 // type is an instance of class template V8StringResource<>,
 // but Mode argument varies; using type (not Mode) for consistency
 // with other macros and ease of code generation
 #define TOSTRING_VOID(type, var, value) \
     type var(value);                    \
     if (UNLIKELY(!var.prepare()))       \
         return;
 
 #define TOSTRING_VOID_INTERNAL(var, value) \
     var = (value);                         \
-    if (UNLIKELY(!var.prepare())) {        \
-        block.ReThrow();                   \
-        return;                            \
-    }
-
-// There are no v8::TryCatch declared outside.
-#define TOSTRING_VOID_INTERNAL_NOTRYCATCH(var, value) \
-    var = (value);                                    \
-    if (UNLIKELY(!var.prepare()))                     \
+    if (UNLIKELY(!var.prepare()))          \
         return;
 
 #define TOSTRING_DEFAULT(type, var, value, retVal) \
     type var(value);                               \
     if (UNLIKELY(!var.prepare()))                  \
         return retVal;
 
 } // namespace WebCore
 
 #endif // V8BindingMacros_h