Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 304183010: Add display_unittests target (Closed)

Created:
6 years, 6 months ago by dnicoara
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add display_unittests target As a first step to getting a separate target for the display unittests, this CL is adding a simple target with one unittest. All display_unittests currently running under ui_unittests will be migrated under this target when display_unittests is enabled on the main waterfall. BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274332

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M build/all.gyp View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M ui/display/display.gyp View 2 chunks +16 lines, -1 line 2 comments Download

Messages

Total messages: 8 (0 generated)
dnicoara
PTAL I've been adding display_unittests only to the common targets that are used on desktop ...
6 years, 6 months ago (2014-06-02 18:27:20 UTC) #1
Peter Mayo
https://codereview.chromium.org/304183010/diff/30001/ui/display/display.gyp File ui/display/display.gyp (right): https://codereview.chromium.org/304183010/diff/30001/ui/display/display.gyp#newcode150 ui/display/display.gyp:150: '../../base/base.gyp:run_all_unittests', Why does this depend on run_all unittests?
6 years, 6 months ago (2014-06-02 19:17:09 UTC) #2
dnicoara
https://codereview.chromium.org/304183010/diff/30001/ui/display/display.gyp File ui/display/display.gyp (right): https://codereview.chromium.org/304183010/diff/30001/ui/display/display.gyp#newcode150 ui/display/display.gyp:150: '../../base/base.gyp:run_all_unittests', On 2014/06/02 19:17:09, Peter Mayo wrote: > Why ...
6 years, 6 months ago (2014-06-02 19:27:53 UTC) #3
Daniel Erat
lgtm
6 years, 6 months ago (2014-06-02 19:41:07 UTC) #4
Peter Mayo
lgtm
6 years, 6 months ago (2014-06-02 19:50:07 UTC) #5
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 6 months ago (2014-06-02 19:54:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/304183010/30001
6 years, 6 months ago (2014-06-02 19:55:48 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:15:21 UTC) #8
Message was sent while issue was closed.
Change committed as 274332

Powered by Google App Engine
This is Rietveld 408576698