Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 304183007: Added ProfilePolicyConnector::IsFromCloudPolicy(). (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Visibility:
Public.

Description

Added ProfilePolicyConnector::IsFromCloudPolicy(). This helper method can be used to determine if a policy comes from the profile cloud policy provider or from another source. It will be used to determine the source of the Managed Bookmarks policy and set the folder name accordingly. BUG=49598 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274142

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M chrome/browser/policy/profile_policy_connector.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 3 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_stub.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/policy/profile_policy_connector_unittest.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 6 months ago (2014-05-30 13:54:33 UTC) #1
pastarmovj
lgtm
6 years, 6 months ago (2014-05-30 14:33:17 UTC) #2
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-05-30 21:05:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/304183007/20001
6 years, 6 months ago (2014-05-30 21:09:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 01:59:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 02:02:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/9272) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70833) linux_chromium_chromeos_rel ...
6 years, 6 months ago (2014-05-31 02:02:52 UTC) #7
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-01 12:43:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/304183007/30001
6 years, 6 months ago (2014-06-01 12:43:19 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-01 15:51:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 15:53:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/33111) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/12187)
6 years, 6 months ago (2014-06-01 15:53:25 UTC) #12
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-06-01 17:18:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/304183007/50001
6 years, 6 months ago (2014-06-01 17:18:39 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 19:51:34 UTC) #15
Message was sent while issue was closed.
Change committed as 274142

Powered by Google App Engine
This is Rietveld 408576698