Issue 304183006: Only store per-navigation permissions for http requests and not https.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304183006: Only store per-navigation permissions for http requests and not https. (Closed)

Created:
6 years, 6 months ago by tommi (sloooow) - chröme

Modified:
6 years, 6 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only store per-navigation permissions for http requests and not https. Doing so caused us to ignore stored content settings for pages accessed via https if a page had been accessed, settings changed and then the page accessed again. BUG=374393 R=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273853

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	chrome/browser/media/media_stream_devices_controller.cc	View		1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

On 2014/05/30 13:18:26, tommi wrote: lgtm

6 years, 6 months ago (2014-05-30 16:11:01 UTC) #2

tommi (sloooow) - chröme

6 years, 6 months ago (2014-05-30 16:56:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r273853 (presubmit successful).

Expand Messages | Collapse Messages