Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 304183005: drive: Always use last_modified stored in ResourceEntry (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Always use last_modified stored in ResourceEntry Update last_modified when closing cache file. BUG=346625 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274181

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -45 lines) Patch
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 6 months ago (2014-05-30 09:44:29 UTC) #1
kinaba
lgtm
6 years, 6 months ago (2014-06-02 06:08:19 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-02 06:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/304183005/20001
6 years, 6 months ago (2014-06-02 06:10:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 07:35:46 UTC) #5
Message was sent while issue was closed.
Change committed as 274181

Powered by Google App Engine
This is Rietveld 408576698