Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 304153017: Revert "[MemSheriff] Disable failing tests." (Closed)

Created:
6 years, 6 months ago by Simon Que
Modified:
6 years, 6 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Revert "[MemSheriff] Disable failing tests." This reverts commit 6cff678a31f4c7676d9743aadd0156d658a2fbf9. The tests should have been fixed with these CLs: https://codereview.chromium.org/310493002/ https://codereview.chromium.org/302153003/ BUG=chromium:379140 NOTRY=true Signed-off-by: Simon Que <sque@chromium.org>; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Simon Que
6 years, 6 months ago (2014-06-02 19:57:58 UTC) #1
groby-ooo-7-16
You can usually TBR those changes - i.e. just add a line TBR=<reviewer> in the ...
6 years, 6 months ago (2014-06-03 02:20:48 UTC) #2
groby-ooo-7-16
lgtm
6 years, 6 months ago (2014-06-03 02:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/304153017/1
6 years, 6 months ago (2014-06-03 02:21:45 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:21:54 UTC) #5
Message was sent while issue was closed.
Change committed as 274482

Powered by Google App Engine
This is Rietveld 408576698