Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304153007: [SyncFS][Reland] Relay callback destruction to TaskRunner on RelayCallbackToTaskRunner (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
peria, nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS][Reland] Relay callback destruction to TaskRunner on RelayCallbackToTaskRunner BUG=378516 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273816

Patch Set 1 #

Patch Set 2 : +RunUntilIdle #

Patch Set 3 : +Flush #

Patch Set 4 : wrap .h.pump to 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -57 lines) Patch
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 1 2 3 4 chunks +72 lines, -50 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper.h.pump View 1 2 3 5 chunks +37 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
PTL. Previous CL (Patch Set 1) was reverted due to a leak: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3153/steps/unit_tests/logs/RunOnOtherThreadTest This is ...
6 years, 6 months ago (2014-05-30 03:55:00 UTC) #1
tzik
Added another thread flush for racy clean up.
6 years, 6 months ago (2014-05-30 04:13:33 UTC) #2
peria
LGTM. Please commit after checking with ASAN.
6 years, 6 months ago (2014-05-30 04:14:52 UTC) #3
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-05-30 06:16:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/304153007/60001
6 years, 6 months ago (2014-05-30 06:20:53 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 10:45:43 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:15:38 UTC) #7
Message was sent while issue was closed. 
Change committed as 273816

Powered by Google App Engine
This is Rietveld 408576698