Issue 304153005: Revert 273575 "Introduce IPC::Channel::Create*() to ensure it be..."

Issue 304153005: Revert 273575 "Introduce IPC::Channel::Create*() to ensure it be..." (Closed)

Created:
6 years, 6 months ago by mattm

Modified:
6 years, 6 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273575 "Introduce IPC::Channel::Create*() to ensure it be..." Broke win compile. > Introduce IPC::Channel::Create*() to ensure it being heap-allocated. > > This change introduces IPC::Channel::Create*() API to turn > IPC::Channel into a heap allocated object. This will allow us to > make Channel a polymorphic class. > > This change also tries to hide Channel::Mode from public API > so that we can simplify channel creation code paths cleaner in > following changes. ChannelProxy has to follow same pattern to > finish this cleanup. Such changes will follow. > > TEST=none > BUG=377980 > R=darin@chromium.org,cpu@chromium.org > > Review URL: https://codereview.chromium.org/307653003 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273596

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -231 lines)			Patch
M	trunk/src/chrome/browser/pepper_flash_settings_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	trunk/src/components/nacl/broker/nacl_broker_listener.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/components/nacl/loader/nacl_ipc_adapter.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/plugin_data_remover_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/plugin_service_impl_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/common/child_process_host_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/renderer/render_thread_impl_browsertest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/ipc/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ipc/ipc.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ipc/ipc_channel.h	View	3 chunks	+14 lines, -43 lines	0 comments	Download
D	trunk/src/ipc/ipc_channel_common.cc	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	trunk/src/ipc/ipc_channel_posix_unittest.cc	View	13 chunks	+67 lines, -84 lines	0 comments	Download
M	trunk/src/ipc/ipc_channel_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ipc/ipc_channel_proxy_unittest.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	trunk/src/ipc/ipc_channel_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	trunk/src/ipc/ipc_fuzzing_tests.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	trunk/src/ipc/ipc_perftests.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	trunk/src/ipc/ipc_send_fds_test.cc	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	trunk/src/ipc/ipc_test_base.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/ipc/sync_socket_unittest.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattm

Committed patchset #1 manually as r273596 (tree was closed).

6 years, 6 months ago (2014-05-29 21:10:33 UTC) #2

mattm

On 2014/05/29 21:10:33, mattm wrote: > Committed patchset #1 manually as r273596 (tree was closed). ...

6 years, 6 months ago (2014-05-29 21:12:59 UTC) #3

Message was sent while issue was closed.

On 2014/05/29 21:10:33, mattm wrote:
> Committed patchset #1 manually as r273596 (tree was closed).

http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/81
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/b...

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\cloud_print\service\win\cloud_print_service_lib.service_listener.obj.rsp /c
..\..\cloud_print\service\win\service_listener.cc
/Foobj\cloud_print\service\win\cloud_print_service_lib.service_listener.obj
/Fdobj\cloud_print\service\cloud_print_service_lib.cc.pdb 
c:\b\build\slave\win_builder__dbg_\build\src\cloud_print\service\win\service_listener.cc(95)
: error C2248: 'IPC::Channel::Channel' : cannot access private member declared
in class 'IPC::Channel'
        c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(249) :
see declaration of 'IPC::Channel::Channel'
        c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(41) : see
declaration of 'IPC::Channel'
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\cloud_print\service\win\cloud_print_service_lib.setup_listener.obj.rsp /c
..\..\cloud_print\service\win\setup_listener.cc
/Foobj\cloud_print\service\win\cloud_print_service_lib.setup_listener.obj
/Fdobj\cloud_print\service\cloud_print_service_lib.cc.pdb 
c:\b\build\slave\win_builder__dbg_\build\src\cloud_print\service\win\setup_listener.cc(121)
: error C2248: 'IPC::Channel::Channel' : cannot access private member declared
in class 'IPC::Channel'
        c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(249) :
see declaration of 'IPC::Channel::Channel'
        c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(41) : see
declaration of 'IPC::Channel'
ninja: build stopped: subcommand failed.

Hajime Morrita

6 years, 6 months ago (2014-05-29 21:21:13 UTC) #4

Message was sent while issue was closed.

On 2014/05/29 21:12:59, mattm wrote:
> On 2014/05/29 21:10:33, mattm wrote:
> > Committed patchset #1 manually as r273596 (tree was closed).
> 
> http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/81
>
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/b...
> 
> FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
> "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
> /showIncludes /FC
> @obj\cloud_print\service\win\cloud_print_service_lib.service_listener.obj.rsp
/c
> ..\..\cloud_print\service\win\service_listener.cc
> /Foobj\cloud_print\service\win\cloud_print_service_lib.service_listener.obj
> /Fdobj\cloud_print\service\cloud_print_service_lib.cc.pdb 
>
c:\b\build\slave\win_builder__dbg_\build\src\cloud_print\service\win\service_listener.cc(95)
> : error C2248: 'IPC::Channel::Channel' : cannot access private member declared
> in class 'IPC::Channel'
>         c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(249) :
> see declaration of 'IPC::Channel::Channel'
>         c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(41) :
see
> declaration of 'IPC::Channel'
> FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
> "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
> /showIncludes /FC
> @obj\cloud_print\service\win\cloud_print_service_lib.setup_listener.obj.rsp /c
> ..\..\cloud_print\service\win\setup_listener.cc
> /Foobj\cloud_print\service\win\cloud_print_service_lib.setup_listener.obj
> /Fdobj\cloud_print\service\cloud_print_service_lib.cc.pdb 
>
c:\b\build\slave\win_builder__dbg_\build\src\cloud_print\service\win\setup_listener.cc(121)
> : error C2248: 'IPC::Channel::Channel' : cannot access private member declared
> in class 'IPC::Channel'
>         c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(249) :
> see declaration of 'IPC::Channel::Channel'
>         c:\b\build\slave\win_builder__dbg_\build\src\ipc\ipc_channel.h(41) :
see
> declaration of 'IPC::Channel'
> ninja: build stopped: subcommand failed.

Thanks for taking care of it. Fixing...

Expand Messages | Collapse Messages