Add support for extended constant pool arrays.

src/factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "factory.h"
 
 #include "conversions.h"
 #include "isolate-inl.h"
 #include "macro-assembler.h"
 
@@ skipping 113 matching lines @@
   CALL_HEAP_FUNCTION(
       isolate(),
       isolate()->heap()->AllocateConstantPoolArray(number_of_int64_entries,
                                                    number_of_code_ptr_entries,
                                                    number_of_heap_ptr_entries,
                                                    number_of_int32_entries),
       ConstantPoolArray);
 }
 
 
+Handle<ConstantPoolArray> Factory::NewExtendedConstantPoolArray(

[ulan, 2014/06/02 12:32:58]

Instead of passing this long list arguments around, what if we introduce
a class NumberOfEntries that stores "int number_of_entries[4]"?

The this function would look like:
NewExtendedConstantPoolArray(NumberOfEntries small, NumberOfEntries extended);

Constant pool would have a method:
NumberOfEntries ConstantPoolArray::number_of_entries(Section section);

This would also simplify SizeFor* methods.

[rmcilroy, 2014/06/03 12:32:28]

Good idea - done.

+    int small_section_int64_entries,
+    int small_section_code_ptr_entries,
+    int small_section_heap_ptr_entries,
+    int small_section_int32_entries,
+    int extended_section_int64_entries,
+    int extended_section_code_ptr_entries,
+    int extended_section_heap_ptr_entries,
+    int extended_section_int32_entries) {
+  ASSERT(small_section_int64_entries > 0 ||
+         small_section_code_ptr_entries > 0 ||
+         small_section_heap_ptr_entries > 0 ||
+         small_section_int32_entries > 0 ||
+         extended_section_int64_entries > 0 ||
+         extended_section_code_ptr_entries > 0 ||
+         extended_section_heap_ptr_entries > 0 ||
+         extended_section_int32_entries > 0);
+  CALL_HEAP_FUNCTION(
+      isolate(),
+      isolate()->heap()->AllocateExtendedConstantPoolArray(
+          small_section_int64_entries,
+          small_section_code_ptr_entries,
+          small_section_heap_ptr_entries,
+          small_section_int32_entries,
+          extended_section_int64_entries,
+          extended_section_code_ptr_entries,
+          extended_section_heap_ptr_entries,
+          extended_section_int32_entries),
+      ConstantPoolArray);
+}
+
+
 Handle<OrderedHashSet> Factory::NewOrderedHashSet() {
   return OrderedHashSet::Allocate(isolate(), 4);
 }
 
 
 Handle<OrderedHashMap> Factory::NewOrderedHashMap() {
   return OrderedHashMap::Allocate(isolate(), 4);
 }
 
 
@@ skipping 2187 matching lines @@
   return Handle<Object>::null();
 }
 
 
 Handle<Object> Factory::ToBoolean(bool value) {
   return value ? true_value() : false_value();
 }
 
 
 } }  // namespace v8::internal