Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 304123002: Remove tests that shouldn't pass according to the current spec. (Closed)

Created:
6 years, 6 months ago by kochi
Modified:
6 years, 6 months ago
Reviewers:
tasak
CC:
blink-reviews, hayato
Visibility:
Public.

Description

Remove tests that shouldn't pass according to the current spec. Some tests in style-with-shadow-pseudo-element.html and style-with-deep-combinator.html did check if a style rule in a shadow tree can be applied to its sibling shadow tree(s), which is against the current spec. I will add some test *against* such case, that a style rule doesn't apply to its sibling shadow tree, along with the fix for bug 355674 later. BUG=355674 TEST=pass layout tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175078

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M LayoutTests/fast/dom/shadow/style-with-deep-combinator.html View 3 chunks +0 lines, -41 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html View 3 chunks +0 lines, -39 lines 1 comment Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Hello Takashi, Could you review? Thanks, https://codereview.chromium.org/304123002/diff/1/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html File LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html (left): https://codereview.chromium.org/304123002/diff/1/LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html#oldcode309 LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html:309: // div::shadow span ...
6 years, 6 months ago (2014-05-29 07:47:19 UTC) #1
tasak
lgtm
6 years, 6 months ago (2014-05-29 07:55:11 UTC) #2
kochi
The CQ bit was checked by kochi@chromium.org
6 years, 6 months ago (2014-05-29 08:36:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/304123002/1
6 years, 6 months ago (2014-05-29 08:38:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 23:11:03 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 00:31:20 UTC) #6
Message was sent while issue was closed.
Change committed as 175078

Powered by Google App Engine
This is Rietveld 408576698