Issue 304113003: DevTools: Reenable the DOM storage agent on reattach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304113003: DevTools: Reenable the DOM storage agent on reattach. (Closed)

Created:
6 years, 6 months ago by eustas

Modified:
6 years, 6 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DevTools: Reenable the DOM storage agent on reattach. BUG=378681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175138

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	Source/core/inspector/InspectorDOMStorageAgent.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/core/inspector/InspectorDOMStorageAgent.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm The issue subject should reflect what this patch does, not the problem it fixes ...

6 years, 6 months ago (2014-05-29 13:27:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/304113003/1

6 years, 6 months ago (2014-05-30 08:38:53 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 6 months ago (2014-05-30 13:48:29 UTC) #5

Message was sent while issue was closed.

Change committed as 175138

Expand Messages | Collapse Messages