Issue 304113002: Pass render frame ID to WebSocketBridge (Blink side)

Issue 304113002: Pass render frame ID to WebSocketBridge (Blink side) (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 6 months ago

Reviewers:
tkent, Adam Rice, yhirano, Paweł Hajdan Jr.

CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Pass render frame ID to WebSocketBridge (Blink side) The browser side code of the new WebSocket stack needs to know the ID of the render frame where the corresponding WebSocketBridge is created in order to handle certificate errors. This CL just ports the code used by the old WebSocket implementation to new one. This CL also contains clean up on the old stack. Chromium side change: https://codereview.chromium.org/308513004/ BUG=364361 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175154

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Addressed #2 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -23 lines)			Patch
M	Source/core/loader/FrameLoaderClient.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/modules/websockets/MainThreadWebSocketChannel.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/websockets/MainThreadWebSocketChannel.cpp	View	1	2 chunks	+8 lines, -9 lines	0 comments	Download
M	Source/modules/websockets/NewWebSocketChannelImpl.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/platform/network/SocketStreamHandle.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/platform/network/SocketStreamHandle.cpp	View	1	3 chunks	+9 lines, -8 lines	0 comments	Download
M	Source/platform/network/SocketStreamHandleClient.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/FrameLoaderClientImpl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/FrameLoaderClientImpl.cpp	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	public/web/WebFrameClient.h	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

yhirano

lgtm https://codereview.chromium.org/304113002/diff/40001/public/web/WebFrameClient.h File public/web/WebFrameClient.h (right): https://codereview.chromium.org/304113002/diff/40001/public/web/WebFrameClient.h#newcode446 public/web/WebFrameClient.h:446: // A WebSocket object is going to open ...

6 years, 6 months ago (2014-05-29 07:19:18 UTC) #2

tyoshino (SeeGerritForStatus)

https://codereview.chromium.org/304113002/diff/40001/public/web/WebFrameClient.h File public/web/WebFrameClient.h (right): https://codereview.chromium.org/304113002/diff/40001/public/web/WebFrameClient.h#newcode446 public/web/WebFrameClient.h:446: // A WebSocket object is going to open new ...

6 years, 6 months ago (2014-05-29 07:29:09 UTC) #3

tyoshino (SeeGerritForStatus)

The CQ bit was checked by tyoshino@chromium.org

6 years, 6 months ago (2014-05-30 03:57:34 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/304113002/60001

6 years, 6 months ago (2014-05-30 04:02:49 UTC) #8

Paweł Hajdan Jr.

The CQ bit was unchecked by phajdan.jr@chromium.org

6 years, 6 months ago (2014-05-30 16:23:54 UTC) #9

Paweł Hajdan Jr.

The CQ bit was checked by phajdan.jr@chromium.org

6 years, 6 months ago (2014-05-30 16:28:51 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/304113002/60001

6 years, 6 months ago (2014-05-30 16:31:21 UTC) #11

Message was sent while issue was closed.

Change committed as 175154

Expand Messages | Collapse Messages