Issue 3041028: [Mac] Reposition the status bubble whenever adding it to a window....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3041028: [Mac] Reposition the status bubble whenever adding it to a window.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by rohitrao (OOO until 6-22)

Modified:
4 years ago

Reviewers:
Avi, Miranda Callahan

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Reposition the status bubble whenever adding it to a window. BUG=50599 TEST=Open a window and let its webpage load. Move the window left or right, without allowing the mouse to pass over the web area. Then type in a new url and load it, again without letting the mouse pass over the web area. Status bubble should appear in the proper place. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54320

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	chrome/browser/cocoa/status_bubble_mac.mm	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/cocoa/status_bubble_mac_unittest.mm	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Trybot results: mac win linux

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (OOO until 6-22)

Unittest even fails before my change and passes after!

4 years, 10 months ago (2010-07-30 03:46:21 UTC) #1

Miranda Callahan

On 2010/07/30 03:46:21, rohitrao wrote: > Unittest even fails before my change and passes after! ...

4 years, 10 months ago (2010-07-30 03:55:06 UTC) #2

Whoo! LG

Expand Messages | Collapse Messages