Issue 3041007: AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3041007: AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by dhollowa

Modified:
4 years ago

Reviewers:
feldstein

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries. Changes the AutoFill dialog on Mac to display list of derived labels and not summaries. BUG=49344 TEST=Manual test as in bug. AutoFillDialogControllerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52957

Patch Set 1 #

Patch Set 2 : Fixing unit tests. #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -3 lines)			Patch
M	chrome/browser/autofill/autofill_dialog_controller_mac.mm	View	6 chunks	+24 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm	View	5 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/web_data_service.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Trybot results: mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

4 years, 10 months ago (2010-07-19 19:59:08 UTC) #3

On 2010/07/19 18:37:41, feldstein wrote:
> LGTM

Adds fixes for unit tests.

Expand Messages | Collapse Messages