Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 3041007: AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by dhollowa
Modified:
4 years ago
Reviewers:
feldstein
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

AutoFill Prefs dialog on Mac should list derived labels for profiles, not summaries. Changes the AutoFill dialog on Mac to display list of derived labels and not summaries. BUG=49344 TEST=Manual test as in bug. AutoFillDialogControllerTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52957

Patch Set 1 #

Patch Set 2 : Fixing unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 6 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm View 5 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
Trybot results:  mac 
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
dhollowa
4 years, 10 months ago (2010-07-19 18:30:47 UTC) #1
feldstein
LGTM
4 years, 10 months ago (2010-07-19 18:37:41 UTC) #2
dhollowa
4 years, 10 months ago (2010-07-19 19:59:08 UTC) #3
On 2010/07/19 18:37:41, feldstein wrote:
> LGTM

Adds fixes for unit tests.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be