Support recovery from SSL errors for new WebSocket implementation

Support recovery from SSL errors.

Previously, the new WebSocket implementation was unable to handle sites
with self-signed certificates and other cases where the user had
overridden certificate errors. Add code to support this case.

This requires adding infrastructure to pass the SSL error back up to the
content layer which knows how to handle it. It also requires that the ID
of the frame be known, so an extra parameter has been added to the
WebSocketHostMsg_AddChannelRequest IPC message.

BUG=364361
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275066

[yhirano, 2014-06-03 05:44:51]

lgtm

https://codereview.chromium.org/304093003/diff/160001/content/browser/rendere...
File content/browser/renderer_host/websocket_host.cc (right):

https://codereview.chromium.org/304093003/diff/160001/content/browser/rendere...
content/browser/renderer_host/websocket_host.cc:355: 
DCHECK(!channel_)

[Adam Rice, 2014-06-03 06:36:50]

https://codereview.chromium.org/304093003/diff/160001/content/browser/rendere...
File content/browser/renderer_host/websocket_host.cc (right):

https://codereview.chromium.org/304093003/diff/160001/content/browser/rendere...
content/browser/renderer_host/websocket_host.cc:355: 
On 2014/06/03 05:44:51, yhirano wrote:
> DCHECK(!channel_)

Done. I also changed the if() conditions in the other methods to DCHECKs, since
it should not be possible to reach them without channel_ being set.

[tyoshino (SeeGerritForStatus), 2014-06-03 12:11:59]

almost lg

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream.cc:46: virtual void
OnReceivedRedirect(URLRequest* request,
write a comment to roughly explain why we never reach here.

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream.cc:208: // more for us to do here.
could you please elaborate this comment?

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_stream_test.cc (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream_test.cc:130: if (!ssl_data_.empty()) {
do you need this?

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_test_util.h (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_test_util.h:72: // read.
write some comment to say that this method "adds" raw expectation.

[Adam Rice, 2014-06-03 12:59:50]

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream.cc:46: virtual void
OnReceivedRedirect(URLRequest* request,
On 2014/06/03 12:11:59, tyoshino wrote:
> write a comment to roughly explain why we never reach here.

Done.

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream.cc:208: // more for us to do here.
On 2014/06/03 12:11:59, tyoshino wrote:
> could you please elaborate this comment?

Done.

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_stream_test.cc (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_stream_test.cc:130: if (!ssl_data_.empty()) {
On 2014/06/03 12:11:59, tyoshino wrote:
> do you need this?

No. Removed.

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
File net/websockets/websocket_test_util.h (right):

https://codereview.chromium.org/304093003/diff/180001/net/websockets/websocke...
net/websockets/websocket_test_util.h:72: // read.
On 2014/06/03 12:11:59, tyoshino wrote:
> write some comment to say that this method "adds" raw expectation.

Done.

[Adam Rice, 2014-06-04 01:21:15]

+tsepez for websocket_messages.h review.

[tyoshino (SeeGerritForStatus), 2014-06-04 04:47:27]

lgtm

[Tom Sepez, 2014-06-04 19:57:27]

Messages LGTM.

[Adam Rice, 2014-06-05 02:38:17]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-06-05 02:41:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ricea@chromium.org/304093003/200001

[commit-bot: I haz the power, 2014-06-05 06:42:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-06-05 06:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 06:46:43]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Adam Rice, 2014-06-05 11:03:46]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-06-05 11:05:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ricea@chromium.org/304093003/200001

[commit-bot: I haz the power, 2014-06-05 11:11:17]

Change committed as 275066