Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304093002: [SyncFS] Check SyncEngine's availability (Closed)

Created:
6 years, 6 months ago by peria
Modified:
6 years, 6 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Check SyncEngine's availability before accessing it. BUG=378516 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
peria
This is a quick fix to avoid crashes. We will take more works in a ...
6 years, 6 months ago (2014-05-29 03:39:46 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-05-29 03:53:30 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-05-29 04:00:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/304093002/1
6 years, 6 months ago (2014-05-29 04:01:58 UTC) #4
nhiroki
lgtm!
6 years, 6 months ago (2014-05-29 04:16:58 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 07:50:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 08:26:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/78791)
6 years, 6 months ago (2014-05-29 08:26:46 UTC) #8
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-05-30 02:37:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/304093002/1
6 years, 6 months ago (2014-05-30 02:38:13 UTC) #10
peria
The CQ bit was unchecked by peria@chromium.org
6 years, 6 months ago (2014-05-30 05:13:06 UTC) #11
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-05-30 05:13:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/304093002/1
6 years, 6 months ago (2014-05-30 05:15:30 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 08:23:24 UTC) #14
Message was sent while issue was closed. 
Change committed as 273769

Powered by Google App Engine
This is Rietveld 408576698