Issue 304073003: DevTools: display reload warning in the responsive design toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304073003: DevTools: display reload warning in the responsive design toolbar. (Closed)

Created:
6 years, 6 months ago by pfeldman

Modified:
6 years, 6 months ago

Reviewers:
dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: display reload warning in the responsive design toolbar. R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175053

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -1 line)			Patch
M	Source/devtools/front_end/ResponsiveDesignView.js	View	1 chunk	+12 lines, -1 line	1 comment	Download
M	Source/devtools/front_end/overrides.css	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/responsiveDesignView.css	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

I wonder how it looks when not enough space? lgtm https://codereview.chromium.org/304073003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/304073003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js#newcode441 ...

6 years, 6 months ago (2014-05-29 11:06:37 UTC) #2

pfeldman

6 years, 6 months ago (2014-05-29 11:39:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r175053 (presubmit successful).

Expand Messages | Collapse Messages