ServiceWorker: support Request.{url,method,origin,headers} [blink] (1/3)

ServiceWorker: support Request.{url,method,origin,headers} [blink] (1/3)

https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#request-objects

Multi-sided patch: 
1/3: blink-side, THIS PATCH
2/3: chromium-side, https://codereview.chromium.org/305893003/
3/3: blink-side, cleanup Not Yet.

BUG=377373
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175276

[horo, 2014-05-29 11:42:22]

falken@
Could you please review this?

[falken, 2014-05-30 02:31:19]

lgtm with nits

https://codereview.chromium.org/304053003/diff/110001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/request-worker.js (right):

https://codereview.chromium.org/304053003/diff/110001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/request-worker.js:12: origin:
'https://www.example.com/',
origin should be removed, it isn't in the spec's RequestInit

https://codereview.chromium.org/304053003/diff/110001/Source/modules/modules....
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/modules....
Source/modules/modules.gypi:652: 'serviceworkers/Request.cpp',
alphabetical ordering: these should be before "RespondWith*"

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
File Source/modules/serviceworkers/Request.idl (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
Source/modules/serviceworkers/Request.idl:5: //
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#re...
Since this patch adds/changes IDL files it's good practice to also include links
to the relevant specs in the CL description.

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
File Source/modules/serviceworkers/RequestInit.h (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
Source/modules/serviceworkers/RequestInit.h:20: options.get("origin", origin);
ditto, remove origin

https://codereview.chromium.org/304053003/diff/110001/public/platform/WebServ...
File public/platform/WebServiceWorkerRequest.h (right):

https://codereview.chromium.org/304053003/diff/110001/public/platform/WebServ...
public/platform/WebServiceWorkerRequest.h:23: class BLINK_PLATFORM_EXPORT
WebServiceWorkerRequest {
maybe include a lightweight comment for this class?

[horo, 2014-05-30 04:04:03]

https://codereview.chromium.org/304053003/diff/110001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/request-worker.js (right):

https://codereview.chromium.org/304053003/diff/110001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/request-worker.js:12: origin:
'https://www.example.com/',
On 2014/05/30 02:31:20, falken wrote:
> origin should be removed, it isn't in the spec's RequestInit

Done.

https://codereview.chromium.org/304053003/diff/110001/Source/modules/modules....
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/modules....
Source/modules/modules.gypi:652: 'serviceworkers/Request.cpp',
On 2014/05/30 02:31:20, falken wrote:
> alphabetical ordering: these should be before "RespondWith*"

Done.

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
File Source/modules/serviceworkers/Request.idl (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
Source/modules/serviceworkers/Request.idl:5: //
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#re...
On 2014/05/30 02:31:20, falken wrote:
> Since this patch adds/changes IDL files it's good practice to also include
links
> to the relevant specs in the CL description.

Done.

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
File Source/modules/serviceworkers/RequestInit.h (right):

https://codereview.chromium.org/304053003/diff/110001/Source/modules/servicew...
Source/modules/serviceworkers/RequestInit.h:20: options.get("origin", origin);
On 2014/05/30 02:31:20, falken wrote:
> ditto, remove origin

Done.

https://codereview.chromium.org/304053003/diff/110001/public/platform/WebServ...
File public/platform/WebServiceWorkerRequest.h (right):

https://codereview.chromium.org/304053003/diff/110001/public/platform/WebServ...
public/platform/WebServiceWorkerRequest.h:23: class BLINK_PLATFORM_EXPORT
WebServiceWorkerRequest {
On 2014/05/30 02:31:20, falken wrote:
> maybe include a lightweight comment for this class?

Done.

[horo, 2014-05-30 05:17:48]

jochen@: could you do owner's review for changes in:
Source/platform/
Source/web/
public/platform/
public/web/

[jochen (gone - plz use gerrit), 2014-06-02 07:23:27]

lgtm

[horo, 2014-06-02 07:55:18]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-06-02 07:55:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/304053003/130001

[commit-bot: I haz the power, 2014-06-02 07:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-02 07:55:42]

Failed to apply patch for Source/platform/blink_platform.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/blink_platform.gypi
  Hunk #1 FAILED at 299.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/platform/blink_platform.gypi.rej

Patch:       Source/platform/blink_platform.gypi
Index: Source/platform/blink_platform.gypi
diff --git a/Source/platform/blink_platform.gypi
b/Source/platform/blink_platform.gypi
index
d38ceca333fb8a9249e446a1d1fb42aa484dacd7..829a4fe27fb682102a8d04eb0b100d42bb3f3e09
100644
--- a/Source/platform/blink_platform.gypi
+++ b/Source/platform/blink_platform.gypi
@@ -299,6 +299,7 @@
       'exported/WebScrollbarThemeGeometryNative.cpp',
       'exported/WebScrollbarThemeGeometryNative.h',
       'exported/WebSerializedOrigin.cpp',
+      'exported/WebServiceWorkerRequest.cpp',
       'exported/WebServiceWorkerResponse.cpp',
       'exported/WebSocketHandshakeRequestInfo.cpp',
       'exported/WebSocketHandshakeResponseInfo.cpp',

[horo, 2014-06-02 10:35:48]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-06-02 10:36:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/304053003/160001

[commit-bot: I haz the power, 2014-06-02 11:48:23]

Change committed as 175276