Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 304053002: A kinder, gentler adbd restart (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

A kinder, gentler adbd restart Background: We restart adbd between runs because we noticed that the likelyhood of an adbd hang goes up with the length of time the process has been running. Killing was just a convenient way to do that, but it isn't the most robust. The chromium.perf bots are very frequently going offline now and they always are getting stuck at the point of the adbd restart. So I'm trying this gentler method of restarting to see if it improves reliability. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274360

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M build/android/pylib/android_commands.py View 1 1 chunk +9 lines, -12 lines 1 comment Download
A build/android/pylib/restart_adbd.sh View 1 1 chunk +20 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
6 years, 6 months ago (2014-05-30 17:30:59 UTC) #1
bulach
lgtm, very cool!! https://codereview.chromium.org/304053002/diff/20001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/304053002/diff/20001/build/android/pylib/android_commands.py#newcode548 build/android/pylib/android_commands.py:548: with DeviceTempFile(self, suffix=".sh") as temp_script_file: nit: ...
6 years, 6 months ago (2014-06-02 11:47:50 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-02 13:56:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/304053002/20001
6 years, 6 months ago (2014-06-02 13:57:23 UTC) #4
navabi
lgtm
6 years, 6 months ago (2014-06-02 18:08:28 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 19:25:53 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 22:43:09 UTC) #7
Message was sent while issue was closed.
Change committed as 274360

Powered by Google App Engine
This is Rietveld 408576698