Issue 304023002: Don't leak a WebServiceWorker when 'current' races with context destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304023002: Don't leak a WebServiceWorker when 'current' races with context destruction. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)

Modified:
6 years, 6 months ago

Reviewers:
falken

CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Don't leak a WebServiceWorker when 'current' races with context destruction. WebServiceWorkerProviderClient::setCurrentServiceWorker passes the ownership of a WebServiceWorker to the container. If the execution context is gone, delete the WebServiceWorker instead of dropping it on the floor. BUG=363967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175023