Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 304013002: [NaCl SDK] Create Filesystem nodes in /dev/fs/... (Closed)

Created:
6 years, 6 months ago by binji
Modified:
6 years, 6 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Create Filesystem nodes in /dev/fs/... These can be used to pass data to a filesystem. I'll use this in the next CL to provide a way to pass data to a JavaScript filesystem. BUG=none R=sbc@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -71 lines) Patch
M native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.h View 2 chunks +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.cc View 6 chunks +54 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/filesystem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/filesystem.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 2 chunks +4 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 2 chunks +14 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 23 chunks +104 lines, -60 lines 0 comments Download
M native_client_sdk/src/libraries/sdk_util/scoped_ref.h View 1 chunk +5 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc View 3 chunks +43 lines, -3 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
binji
6 years, 6 months ago (2014-05-29 00:36:45 UTC) #1
Sam Clegg
6 years, 6 months ago (2014-05-29 00:43:59 UTC) #2
nice.

lgtm.

Powered by Google App Engine
This is Rietveld 408576698