Add browser test for ChromeResourceDispatcherHostDelegate.

chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fa89e8e53c41de3af0560204525c31e479fdee92
--- /dev/null
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
@@ -0,0 +1,180 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/strings/string_util.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/policy/cloud/policy_header_service_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "components/policy/core/common/cloud/cloud_policy_constants.h"
+#include "components/policy/core/common/cloud/policy_header_io_helper.h"
+#include "components/policy/core/common/cloud/policy_header_service.h"
+#include "components/policy/core/common/policy_switches.h"
+#include "content/public/browser/resource_dispatcher_host.h"
+#include "net/http/http_request_headers.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
+#include "net/test/embedded_test_server/http_request.h"
+#include "net/test/embedded_test_server/http_response.h"
+#include "net/url_request/url_request.h"
+
+namespace {
+static const char kTestPolicyHeader[] = "test_header";
+static const char kServerRedirectUrl[] = "/server-redirect";
+
+scoped_ptr<net::test_server::HttpResponse> HandleTestRequest(
+    const net::test_server::HttpRequest& request) {
+  if (StartsWithASCII(request.relative_url, kServerRedirectUrl, true)) {
+    // Extract the target URL and redirect there.
+    size_t query_string_pos = request.relative_url.find('?');
+    std::string redirect_target =
+        request.relative_url.substr(query_string_pos + 1);
+
+    scoped_ptr<net::test_server::BasicHttpResponse> http_response(
+        new net::test_server::BasicHttpResponse);
+    http_response->set_code(net::HTTP_MOVED_PERMANENTLY);
+    http_response->AddCustomHeader("Location", redirect_target);
+    return http_response.PassAs<net::test_server::HttpResponse>();
+  } else {
+    scoped_ptr<net::test_server::BasicHttpResponse> http_response(
+        new net::test_server::BasicHttpResponse);
+    http_response->set_code(net::HTTP_OK);
+    http_response->set_content("Success");
+    return http_response.PassAs<net::test_server::HttpResponse>();
+  }
+}
+
+class TestDispatcherHostDelegate : public ChromeResourceDispatcherHostDelegate {
+ public:
+  TestDispatcherHostDelegate(

[jochen (gone - plz use gerrit), 2014/06/06 07:18:39]

explicit

[Andrew T Wilson (Slow), 2014/06/06 08:42:19]

Done.

+      prerender::PrerenderTracker* prerender_tracker)
+      : ChromeResourceDispatcherHostDelegate(prerender_tracker) {
+  }
+
+  virtual ~TestDispatcherHostDelegate() {}
+
+  virtual void RequestBeginning(
+      net::URLRequest* request,
+      content::ResourceContext* resource_context,
+      appcache::AppCacheService* appcache_service,
+      ResourceType::Type resource_type,
+      int child_id,
+      int route_id,
+      ScopedVector<content::ResourceThrottle>* throttles) OVERRIDE {
+    ChromeResourceDispatcherHostDelegate::RequestBeginning(
+        request,
+        resource_context,
+        appcache_service,
+        resource_type,
+        child_id,
+        route_id,
+        throttles);
+    request_headers_.MergeFrom(request->extra_request_headers());
+  }
+
+  virtual void OnRequestRedirected(
+      const GURL& redirect_url,
+      net::URLRequest* request,
+      content::ResourceContext* resource_context,
+      content::ResourceResponse* response) OVERRIDE {
+    ChromeResourceDispatcherHostDelegate::OnRequestRedirected(
+        redirect_url,
+        request,
+        resource_context,
+        response);
+    request_headers_.MergeFrom(request->extra_request_headers());
+  }
+
+  net::HttpRequestHeaders request_headers_;

[jochen (gone - plz use gerrit), 2014/06/06 07:18:39]

should be private

[Andrew T Wilson (Slow), 2014/06/06 08:42:19]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(TestDispatcherHostDelegate);
+};
+
+}  // namespace
+
+class ChromeResourceDispatcherHostDelegateBrowserTest :
+    public InProcessBrowserTest {
+ public:
+
+  virtual void SetUpOnMainThread() OVERRIDE {
+    InProcessBrowserTest::SetUpOnMainThread();
+    // Hook navigations with our delegate.
+    dispatcher_host_delegate_.reset(new TestDispatcherHostDelegate(
+        g_browser_process->prerender_tracker()));
+    content::ResourceDispatcherHost::Get()->SetDelegate(
+        dispatcher_host_delegate_.get());
+
+    embedded_test_server()->RegisterRequestHandler(
+        base::Bind(&HandleTestRequest));
+    ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+    // Tell chrome that this is our DM server.
+    dm_url_ = embedded_test_server()->GetURL("/DeviceManagement");
+
+    // At this point, the Profile is already initialized and it's too
+    // late to set the DMServer URL via command line flags, so directly
+    // inject it to the PolicyHeaderIOHelper.
+    policy::PolicyHeaderService* policy_header_service =
+        policy::PolicyHeaderServiceFactory::GetForBrowserContext(
+            browser()->profile());
+    std::vector<policy::PolicyHeaderIOHelper*> helpers =
+        policy_header_service->GetHelpersForTest();
+    for (std::vector<policy::PolicyHeaderIOHelper*>::const_iterator it =
+             helpers.begin();
+         it != helpers.end(); ++it) {
+      (*it)->SetServerURLForTest(dm_url_.spec());
+      (*it)->UpdateHeader(kTestPolicyHeader);
+    }
+  }
+
+  virtual void CleanUpOnMainThread() OVERRIDE {
+    dispatcher_host_delegate_.reset();
+    InProcessBrowserTest::CleanUpOnMainThread();
+  }
+
+  // The fake URL for DMServer we are using.
+  GURL dm_url_;

[jochen (gone - plz use gerrit), 2014/06/06 07:18:39]

private

[Andrew T Wilson (Slow), 2014/06/06 08:42:19]

I use these in the tests below, so they must be public.

[jochen (gone - plz use gerrit), 2014/06/06 13:43:50]

tests inherit from their fixture, so protected should work

or getters/setters :)

+  scoped_ptr<TestDispatcherHostDelegate> dispatcher_host_delegate_;
+};

[jochen (gone - plz use gerrit), 2014/06/06 07:18:39]

disallow copy & assign

[Andrew T Wilson (Slow), 2014/06/06 08:42:19]

Done.

+
+
+IN_PROC_BROWSER_TEST_F(ChromeResourceDispatcherHostDelegateBrowserTest,
+                       NoPolicyHeader) {
+  // When fetching non-DMServer URLs, we should not add a policy header to the
+  // request.
+  DCHECK(!embedded_test_server()->base_url().spec().empty());
+  ui_test_utils::NavigateToURL(browser(), embedded_test_server()->base_url());
+  ASSERT_FALSE(dispatcher_host_delegate_->request_headers_.HasHeader(
+      policy::kChromePolicyHeader));
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeResourceDispatcherHostDelegateBrowserTest,
+                       PolicyHeader) {
+  // When fetching a DMServer URL, we should add a policy header to the
+  // request.
+  ui_test_utils::NavigateToURL(browser(), dm_url_);
+  std::string value;
+  ASSERT_TRUE(dispatcher_host_delegate_->request_headers_.GetHeader(
+      policy::kChromePolicyHeader, &value));
+  ASSERT_EQ(kTestPolicyHeader, value);
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeResourceDispatcherHostDelegateBrowserTest,
+                       PolicyHeaderForRedirect) {
+
+  // Build up a URL that results in a redirect to the DMServer URL to make
+  // sure the policy header is still added.
+  std::string redirect_url;
+  redirect_url += kServerRedirectUrl;
+  redirect_url += "?";
+  redirect_url += dm_url_.spec();
+  ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(
+      redirect_url));
+  std::string value;
+  ASSERT_TRUE(dispatcher_host_delegate_->request_headers_.GetHeader(
+      policy::kChromePolicyHeader, &value));
+  ASSERT_EQ(kTestPolicyHeader, value);
+}