Issue 303933002: WTC: Started port of patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303933002: WTC: Started port of patch (Closed)

Created:
6 years, 6 months ago by wtc

Modified:
6 years, 6 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[This CL has been abandoned.] WTC: Started port of patch

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -132 lines)			Patch
M	net/base/net_error_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/crypto/channel_id.h	View	1 chunk	+22 lines, -13 lines	0 comments	Download
M	net/quic/crypto/channel_id_test.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.h	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.cc	View	3 chunks	+14 lines, -8 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.cc	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils_nss.cc	View	3 chunks	+41 lines, -44 lines	1 comment	Download
M	net/quic/test_tools/crypto_test_utils_openssl.cc	View	3 chunks	+42 lines, -40 lines	0 comments	Download
M	net/socket/nss_ssl_util.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_client.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

wtc

6 years, 6 months ago (2014-05-28 22:02:00 UTC) #1

https://codereview.chromium.org/303933002/diff/1/net/quic/test_tools/crypto_t...
File net/quic/test_tools/crypto_test_utils_nss.cc (right):

https://codereview.chromium.org/303933002/diff/1/net/quic/test_tools/crypto_t...
net/quic/test_tools/crypto_test_utils_nss.cc:91: crypto::ECPrivateKey*
ec_private_key_;

Note that the destructor of this class does not delete ec_private_key_. This is
not ideal, but is necessary. The reason is that the HostnameToKey() method
returns a cached copy of crypto::ECPrivateKey. So objects of this class cannot
outlive the ChannelIDSource.

It is possible to eliminate this restriction by having HostnameToKey() return a
duplicate copy of crypto::ECPrivateKey. That requires adding a Copy() method to
the crypto::ECPrivateKey class.

Expand Messages | Collapse Messages